NREL mismatch loss addendum (#2147)

* Preliminar implementation, tests, docs and gallery example

I expect to extend the gallery example for a day's RMAD profiling.

* Update versionadded

* Add example

* docstring update

* Update v0.11.0.rst

* who would have guessed it's always the linter?

* Update plot_irradiance_nonuniformity_loss.py

* equation fixes

* RMAD properties application typo

* does this fix the link?

* yet another link

* These links will never work, I suppose

* Move some "Notes" equations to example and rearrange things there

* give this equation it's space

* eq rendering fixes?

* maths are not mathing today

* ???

* ??? x2

* ??? x3

* i feel stupid for this

* Change preprint ref to published one

Co-Authored-By: Kevin Anderson <[email protected]>

* Published paper coeffs

Co-Authored-By: Kevin Anderson <[email protected]>

* Lots of improvements

Pending second section of example, and checking docs

Co-Authored-By: César Domínguez <[email protected]>
Co-Authored-By: Kevin Anderson <[email protected]>

* Linter - also missing Eq (7)

Co-Authored-By: César Domínguez <[email protected]>
Co-Authored-By: Kevin Anderson <[email protected]>

* Test polynomial input

Co-Authored-By: César Domínguez <[email protected]>

* Math

* Test exception

* Update pvsystem.py

* Update plot_irradiance_nonuniformity_loss.py

* Add fill factor ratio

Co-Authored-By: Kevin Anderson <[email protected]>

* ª

* Trying new things

* Revert "Trying new things"

This reverts commit 8a19a4d.

* Update pvsystem.py

* :(

* :((

* I hope we dont miss that reference

* Update pvsystem.py

* Remove second section of the example

* Minor text upgrade

* Update pvsystem.py

* Port to namespace `pvlib.bifacial`

Co-Authored-By: Cliff Hansen <[email protected]>

* Rename to ``power_mismatch_deline``, document in ``bifacial.rst``

Co-Authored-By: Cliff Hansen <[email protected]>

* fillfactor only for predefined models

Co-Authored-By: Cliff Hansen <[email protected]>

* Docstring rewording

Co-Authored-By: Cliff Hansen <[email protected]>

* Linter

* More docs rewording

Co-Authored-By: Cliff Hansen <[email protected]>

* Apply suggestions from Dax

Co-authored-by: RDaxini <[email protected]>

* Unneded image Dominguez_et_al_PVSC2023.png

* Rename file

* Fix equations

* yup it didnt save

* lintaaaaaaarrrr

* Eq 7 numbering

* Revert unintended changes

* Adam code review

Co-Authored-By: Adam R. Jensen <[email protected]>

* Links?

Co-Authored-By: Adam R. Jensen <[email protected]>

* Referencing equations manually

Co-Authored-By: Adam R. Jensen <[email protected]>

* Polynomial links

Co-Authored-By: Adam R. Jensen <[email protected]>

* Dont abuse math mode

* Update loss_models.py

* I forgot

* Adam Code Review

Co-Authored-By: Adam R. Jensen <[email protected]>

* whatsnews

* Update v0.11.0.rst

* Weird that some tests pass and others dont

* Update loss_models.py

* document

* Update loss_models.py

* Kevin's review (I)

Co-Authored-By: Kevin Anderson <[email protected]>

* Kevin's review (II)

Co-Authored-By: Kevin Anderson <[email protected]>

* Kevin's review (III)

Co-Authored-By: Kevin Anderson <[email protected]>

* Update v0.11.1.rst

Co-Authored-By: Kevin Anderson <[email protected]>

* minor changes

* Forgot to update tests

Co-Authored-By: Kevin Anderson <[email protected]>

* Accordingly modify model, IO, docs to unitless model

Co-Authored-By: Kevin Anderson <[email protected]>

* Update loss_models.py

* Update loss_models.py

Co-Authored-By: Kevin Anderson <[email protected]>

* Apply suggestions from code review

Co-authored-by: Cliff Hansen <[email protected]>

* Code review from Cliff

Co-Authored-By: Cliff Hansen <[email protected]>

* Rendering issues, code review from Kevin

Co-Authored-By: Kevin Anderson <[email protected]>

* Little missing newline

* RMAD func definition addendum

Co-Authored-By: Chris Deline <[email protected]>

* Update v0.11.1.rst

* Add RMAD eq to docstring

* Cliff suggestion

Co-Authored-By: Cliff Hansen <[email protected]>

---------

Co-authored-by: Kevin Anderson <[email protected]>
Co-authored-by: César Domínguez <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Chris Deline <[email protected]>

Author: 7 people

docs/examples/bifacial/plot_irradiance_nonuniformity_loss.py

@@ -100,13 +100,12 @@
 #
 
 
-def rmad(data, axis=None):
+def rmad(data):
     """
-    Relative Mean Absolute Difference. Output is [Unitless].
-    https://stackoverflow.com/a/19472336/19371110
+    Relative Mean Absolute Difference. Output is [Unitless]. Eq. (4) of [1]_.
     """
-    mean = np.mean(data, axis)
-    mad = np.mean(np.absolute(data - mean), axis)
+    mean = np.mean(data)
+    mad = np.mean(np.absolute(np.subtract.outer(data, data)))
     return mad / mean
 
 

docs/sphinx/source/whatsnew/v0.11.1.rst

@@ -49,6 +49,8 @@ Requirements
 
 Contributors
 ~~~~~~~~~~~~
+* Echedey Luis (:ghuser:`echedey-ls`)
+* Chris Deline (:ghuser:`cdeline`)
 * Ioannis Sifnaios (:ghuser:`IoannisSifnaios`)
 * Leonardo Micheli (:ghuser:`lmicheli`)
 * Echedey Luis (:ghuser:`echedey-ls`)

pvlib/bifacial/loss_models.py

@@ -71,7 +71,7 @@ def power_mismatch_deline(
     where the upper equation is in percentage (same as paper) and the lower
     one is unitless. The implementation uses the unitless version, where
     :math:`M[-]` is the mismatch power loss [unitless] and
-    :math:`\Delta[-]` is the Relative Mean Absolute Difference [unitless]
+    :math:`\Delta[-]` is the Relative Mean Absolute Difference (RMAD) [unitless]
     of the global irradiance, Eq. (4) of [1]_ and [2]_.
     Note that the n-th power coefficient is multiplied by :math:`100^{n-1}`
     to convert the percentage to unitless.
@@ -101,6 +101,14 @@ def power_mismatch_deline(
        The global irradiance RMAD is different from the backside irradiance
        RMAD.
 
+    RMAD of a variable :math:`G_{total}` is defined as:
+
+    .. math::
+
+        RMAD \left[ unitless \right] = \Delta \left[ unitless \right] =
+        \frac{1}{n^2 \bar{G}_{total}} \sum_{i=1}^{n} \sum_{j=1}^{n}
+        \lvert G_{total,i} - G_{total,j} \rvert
+
     In case the RMAD of the backside irradiance is known, the global RMAD can
     be calculated as follows, assuming the front irradiance RMAD is
     negligible [2]_: