Skip to content

Commit 859a7ce

Browse files
AdamRJensencwhanse
andauthored
Update get_ground_diffuse description (#1883)
* Update documentation * Add Cliff's statement * undo edits to v0.10.3 whatsnew * whatsnew * Update pvlib/irradiance.py --------- Co-authored-by: Cliff Hansen <[email protected]>
1 parent ffb86bb commit 859a7ce

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

docs/sphinx/source/whatsnew/v0.10.4.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Testing
2121
Documentation
2222
~~~~~~~~~~~~~
2323
* Fixed broken URLs in various docstrings. (:pull:`1957`)
24+
* Clarified documentation for :py:func:`~pvlib.irradiance.get_ground_diffuse`. (:pull:`1883`)
2425

2526
Requirements
2627
~~~~~~~~~~~~
@@ -29,3 +30,4 @@ Requirements
2930
Contributors
3031
~~~~~~~~~~~~
3132
* :ghuser:`matsuobasho`
33+
* Adam R. Jensen (:ghuser:`AdamRJensen`)

pvlib/irradiance.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,9 @@ def poa_components(aoi, dni, poa_sky_diffuse, poa_ground_diffuse):
553553
def get_ground_diffuse(surface_tilt, ghi, albedo=.25, surface_type=None):
554554
'''
555555
Estimate diffuse irradiance from ground reflections given
556-
irradiance, albedo, and surface tilt.
556+
irradiance, albedo, and surface tilt. The ground is assumed to
557+
be horizontal, flat and Lambertian, and the reflected irradiance
558+
is isotropic.
557559
558560
Function to determine the portion of irradiance on a tilted surface
559561
due to ground reflections. Any of the inputs may be DataFrames or

0 commit comments

Comments
 (0)