Skip to content

Commit d5d1d66

Browse files
JoLo90Johann Louxcwhanse
authored
Correct cloud_cover_to_transmittance_linear documentation (#1370)
* Modify cloud_cover_to_transmittance_linear documentation replacing ghi with transmittance * Add documentation lines into v0.9.1.rst * Modify line length in documentation * Small modifs doc forecast.py * Small modifs doc forecast.py * Update pvlib/forecast.py Co-authored-by: Cliff Hansen <[email protected]> * Rewording documentation forecast.py Co-authored-by: Johann Loux <jloux@∂exma.com> Co-authored-by: Cliff Hansen <[email protected]>
1 parent 12d8295 commit d5d1d66

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

docs/sphinx/source/whatsnew/v0.9.1.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ Testing
3030

3131
Documentation
3232
~~~~~~~~~~~~~
33+
* Fix documentation return error in :py:meth:`pvlib.forecast.ForecastModel.cloud_cover_to_transmittance_linear`
34+
(:issue:`1367`, :pull:`1370`)
35+
3336

3437
Requirements
3538
~~~~~~~~~~~~
@@ -42,3 +45,4 @@ Contributors
4245
* Christian Weickhmann (:ghuser:`cweickhmann`)
4346
* Kevin Anderson (:ghuser:`kanderso-nrel`)
4447
* Adam R. Jensen (:ghuser:`AdamRJensen`)
48+
* Johann Loux (:ghuser:`JoLo90`)

pvlib/forecast.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -512,10 +512,10 @@ def cloud_cover_to_irradiance_clearsky_scaling(self, cloud_cover,
512512
def cloud_cover_to_transmittance_linear(self, cloud_cover, offset=0.75,
513513
**kwargs):
514514
"""
515-
Convert cloud cover to atmospheric transmittance using a linear
516-
model.
515+
Convert cloud cover (percentage) to atmospheric transmittance
516+
using a linear model.
517517
518-
0% cloud cover returns offset.
518+
0% cloud cover returns "offset".
519519
520520
100% cloud cover returns 0.
521521
@@ -524,14 +524,15 @@ def cloud_cover_to_transmittance_linear(self, cloud_cover, offset=0.75,
524524
cloud_cover : numeric
525525
Cloud cover in %.
526526
offset : numeric, default 0.75
527-
Determines the maximum transmittance.
527+
Determines the maximum transmittance. [unitless]
528528
kwargs
529529
Not used.
530530
531531
Returns
532532
-------
533-
ghi : numeric
534-
Estimated GHI.
533+
transmittance : numeric
534+
The fraction of extraterrestrial irradiance that reaches
535+
the ground. [unitless]
535536
"""
536537
transmittance = ((100.0 - cloud_cover) / 100.0) * offset
537538

0 commit comments

Comments
 (0)