Skip to content

Add map_variables argument to get_pvgis_tmy #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamRJensen opened this issue Jun 29, 2021 · 0 comments · Fixed by #1268
Closed

Add map_variables argument to get_pvgis_tmy #1250

AdamRJensen opened this issue Jun 29, 2021 · 0 comments · Fixed by #1268

Comments

@AdamRJensen
Copy link
Member

AdamRJensen commented Jun 29, 2021

With the addition of the get_pvgis_hourly function (#1186) a variable map dictionary for PVGIS has been added to the PVGIS iotools module.

This issue is raised to add a map_variables boolean input to the read_pvgis_tmy and the get_pvgis_tmy functions to follow the standard for the iotools functions.

While it is a minor change, it is a breaking change as the default for map_variables should be True.

Note: the pvgis_hourly and pvgis_tmy functions should use the same variable map dictionary, hence this feature should first be implemented once #1186 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant