Skip to content

Incorrect irradiance used in pvsystem.ipynb tutorial #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ejmiller2 opened this issue Mar 5, 2016 · 2 comments · Fixed by #136
Closed

Incorrect irradiance used in pvsystem.ipynb tutorial #127

ejmiller2 opened this issue Mar 5, 2016 · 2 comments · Fixed by #136
Labels
documentation
Milestone
0.3.0

Comments

@ejmiller2
Copy link
Contributor

In the tutorial pvsystem.ipynb, In [54] reads:

sapm_1 = pvsystem.sapm(sandia_module, irrad_data['dni']*np.cos(np.radians(aoi)),
                     irrad_data['ghi'], temps['temp_cell'], am, aoi)

I believe the poa_diffuse parameter should use irrad_data['dhi'] instead of irrad_data['ghi'].
@wholmgren
Copy link
Member

Yes, thanks for pointing that out.

@wholmgren wholmgren added this to the 0.3 milestone Mar 5, 2016
@dacoex
Copy link
Contributor

dacoex commented Mar 6, 2016

@wholmgren will look at this when porting the tuts.
Sorry for the delay. some biz came in between.

@wholmgren wholmgren mentioned this issue Mar 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

update tutorials for version 0.3.0 wholmgren/pvlib-python
3 participants
@wholmgren @ejmiller2 @dacoex