Skip to content

Missing explanation of mounting type in document #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1424
miettal opened this issue Oct 14, 2021 · 1 comment · Fixed by #2293
Closed
Tracked by #1424

Missing explanation of mounting type in document #1323

miettal opened this issue Oct 14, 2021 · 1 comment · Fixed by #2293

Comments

@miettal
Copy link

miettal commented Oct 14, 2021

Describe the bug

pvlib.temperature.sapm_cell and pvlib.temperature.sapm_module can be specified coefficient a and b.
and It's depends on module and mounting.
In document, mounting method is listed, but is not described detail.

On the other hand, mounting method detail was described in NREL SAM Help System, and also mentioned in NREL SAM forum.
help system code: https://github.com/NREL/SAM/blob/master/deploy/runtime/help/html/pv_module.htm
forum: https://sam.nrel.gov/forum/forum-general/1040-mount-types.html?start=0

This is missing of mounting type explanation in the document.

To Reproduce

Expected behavior

Explanations of mounting types are described in the document.

Screenshots

Versions:

0.9.0

Additional context

(if this issue have to be a Support question, I re-ask in StackOverflow)

@cwhanse
Copy link
Member

cwhanse commented Oct 14, 2021

@miettal thanks for pointing out this shortcoming in the documentation. I think we can add text to each function's docstring. The racking_model keyword for pvlib.pvsystem.PVSystem doesn't provide much explanation either, but that could point to the documentation for functions in pvlib.temperature. Pull request welcome.

@cwhanse cwhanse mentioned this issue Mar 14, 2022
14 tasks
@kandersolar kandersolar modified the milestones: 0.9.1, 0.9.2 Mar 29, 2022
@kandersolar kandersolar modified the milestones: 0.9.2, 0.9.3 Aug 19, 2022
@kandersolar kandersolar modified the milestones: 0.9.3, 0.9.4 Sep 14, 2022
@kandersolar kandersolar mentioned this issue Dec 9, 2022
9 tasks
@kandersolar kandersolar modified the milestones: 0.9.4, 0.9.5 Dec 14, 2022
@kandersolar kandersolar modified the milestones: 0.9.5, 0.9.6 Mar 18, 2023
@kandersolar kandersolar modified the milestones: 0.9.6, 0.10.0, Someday May 16, 2023
@cwhanse cwhanse self-assigned this Nov 11, 2024
@kandersolar kandersolar modified the milestones: Someday, v0.11.2 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants