You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ModelChain.run_model_from_effective_irradiance requires that the ModelChain instance has attributes which the method doesn't use, e.g., ModelChain.aoi_model. It would be nice if the method runs without requiring these attributes.
"It's a small inelegance that specifying aoi_model is necessary for a ModelChain that only uses run_model_from_effective_irradiance. I don't see a way around it, so I don't think there's anything to be done in this PR, just thinking out loud about the ModelChain design."
The text was updated successfully, but these errors were encountered:
cwhanse
changed the title
It's a small inelegance that specifying aoi_model is necessary for a ModelChain that only uses run_model_from_effective_irradiance. I don't see a way around it, so I don't think there's anything to be done in this PR, just thinking out loud about the ModelChain design.
Reduce required inputs for ModelChain.run_model_from_effective_irradiance
Feb 24, 2022
It would be nice if the method runs without requiring these attributes.
Isn't the problem that the method must be specified when the ModelChain object is instantiated? If so, a better design might be different ModelChain classes such as ModelChain3Component, and ModelChainEffectiveIrradiance. Then each would have its own run_model rather than run_model_.*. Of course that's a pretty substantial API change and may or may not be worth it. Setting different defaults and raising errors at runtime if needed would be a relatively small change, but is less consistent with one of the original goals of ModelChain (if you can build it, you can run it).
Uh oh!
There was an error while loading. Please reload this page.
ModelChain.run_model_from_effective_irradiance
requires that theModelChain
instance has attributes which the method doesn't use, e.g.,ModelChain.aoi_model
. It would be nice if the method runs without requiring these attributes."It's a small inelegance that specifying
aoi_model
is necessary for a ModelChain that only usesrun_model_from_effective_irradiance
. I don't see a way around it, so I don't think there's anything to be done in this PR, just thinking out loud about the ModelChain design."Originally posted by @kanderso-nrel in #1394 (comment)
The text was updated successfully, but these errors were encountered: