Skip to content

Control tolerance for assert_frame_equal #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwhanse opened this issue Jul 12, 2022 · 1 comment
Open

Control tolerance for assert_frame_equal #1491

cwhanse opened this issue Jul 12, 2022 · 1 comment
Labels
Milestone

Comments

@cwhanse
Copy link
Member

cwhanse commented Jul 12, 2022

It would be nice to be able to supply atol and/or rtol to pvlib.conftest.assert_frame_equal.

For any pandas > 1.1, current behavior sets either atol, rtol = [1e-3, 1e-3] or atol, rtol = [1e-5, 1e-5]. If atol or rtol are specified they are silently ignored.

Describe the solution you'd like
Pass atol and rtol through to pd.testing.assert_frame_equal

Describe alternatives you've considered
Live with it and compute more accurate test solutions.

@wholmgren
Copy link
Member

NEP-29 says we can increase the minimum pandas to 1.1 and get rid of the test silliness.

@cwhanse cwhanse added the testing label Dec 9, 2022
@cwhanse cwhanse added this to the 0.10.0 milestone Dec 9, 2022
@kandersolar kandersolar modified the milestones: 0.10.0, Someday May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants