-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update default transposition model #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose this would seen as a "breaking change" and would have to wait until 0.11.0 if we choose to do this. |
I agree with changing the default. IIRC there is some work by Matt Lave that showed Hay-Davies was mildly better when one starts with satellite-based GHI, and Perez better if starting with ground measured GHI. Either is OK with me as a better default. |
It would be great if |
I’m fine with using a solar constant as default for ET DNI. For example either 1367[Wm-2] or 1400[Wm-2] would be fine as a placeholder for a more exact value imo |
This seems like a good approach to me. I suppose it should be incorporated here: pvlib-python/pvlib/irradiance.py Lines 454 to 455 in 46851d9
What would be the best way of assessing if the index is datetime? Something like this:
|
I would like to throw my vote in the hat for Perez as the default transposition model, about 90% of predictions run in PlantPredict use the Perez model (this is without regard to the source of the meteorological data). This is an imperfect measure of true usage industry wide, but I think it is a nice data point. |
Seems like we can and should do a deprecation period for this first. That can be implemented any time, so I've removed the v0.11.0 milestone from this issue. |
Having the default transposition model be isotropic seems like a very poor choice. Isotropic models are known to have very large biases and should only be used in very specific use cases (generally not be new users).
I did a brief survey of commercial software and found that the vast majority only offer the Hay-Davirs and Perez model, with the 1990 Perez model seeming to be favored as the default model.
It would seem to make sense to have the same default model used in
pvlib.modelchain.ModelChain
.pvlib-python/pvlib/irradiance.py
Lines 305 to 310 in cb4c135
The text was updated successfully, but these errors were encountered: