You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good catch. I'm surprised that we've not seen this until now.
I agree that adding **kwargs to get_data is the cleanest way forward. I try to avoid using kwargs in the pvlib API, but we're already using it extensively within forecast.py and I don't see another good option.
Describe the bug
forecast.get_processed_data
accepts**kwargs
(good) and passes these toget_data
(good) andprocess_data
(good):pvlib-python/pvlib/forecast.py
Line 306 in 91c6a55
but
get_data
doesn't allow superfluous keyword arguments (bad):pvlib-python/pvlib/forecast.py
Lines 202 to 204 in 91c6a55
Is the fix just to add
**kwargs
as the last argument toget_data
? If so, you can assign this issue to me and I'll make a PR.To Reproduce
Yields
Expected behavior
I expect that
get_processed_data
is equivalent to:Note how I can pass
extra_kwarg
without any problem.Versions:
pvlib.__version__
: 0.6.3pandas.__version__
: 0.24.2The text was updated successfully, but these errors were encountered: