-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rethinking pvlib.ivtools #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
-1 on pvanalytics, IMO generating inverter and PV-module parameters should be the job of pvlib My personal preference would be to split
or another way to split them would be |
I'd favor |
+/- 0 on moving the fit code to -1 on adding it to existing +1 on breaking up -1 on a |
ok to close this @cwhanse? |
yes |
When I proposed
pvlib.ivtools
I had in mind only the use case of fitting single diode models for PV modules. I expect to see PRs soon with a function to fit the Sandia inverter model (to measured efficiency curves), and functions for the Loss Factor Model. These don't meet the narrow scope of the currentivtools
. There are likely other model fitting functions that could be of interest to pvlib users.#708 refactors
ivtools
to separate functions into modulessde
andsdm
for single diode equation and model fitting, respectively. In hindsight,ivtools
is too generic, since it doesn't communicate what the module does besides something with IV curves.An alternate home for model fitting functions, including those in
ivtools
, might be pvanalytics. But the inverter model fitting code doesn't seem natural there, either, sincepvanalytics
is primarily being designed for analysis of time-series data from PV systems.Options:
pvlib.ivtools
, and stickfit_inverter_snl
(or whatever it's named) intopvlib.pvsystem
.fit_inverter_snl
intopvlib.pvsystem
or merge Create inverter.py #886 and addfit_inverter_snl
there.ivtools
to contain all model fitting functions, divided up into appropriate modules.Other ideas?
The text was updated successfully, but these errors were encountered: