-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve docstring or behavior for irradiance.get_total_irradiance and irradiance.get_sky_diffuse #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
irradiance.get_total_irradiance
Consider also specifying it is relative airmass. |
This came up again in @mikofski's thread here. @mikofski proposed calculating values if needed and not provided. @kanderso-nrel proposed a couple of solutions to provide more informative error messages: 1. hard coding the failure modes in And repeating my take from the thread: I'd rather not introduce the complexity of decorators to the lower level pvlib functions to solve this problem. Ideas that I support:
Does someone want to tackle this in 0.8.0 or should we kick it down the road? |
I think it's tempting to add it in v0.8, but I'm in favor of freezing features now and pushing out the release sooner with the features we already have queued. It's been a while, and I think we should deploy more often with less features per release. I believe this will make it easier to blame issues and get more testing done on new features and fixes faster. |
I'll volunteer to take this up for v0.8.1, since I was the complainer. |
pvlib-python/pvlib/pvsystem.py Lines 289 to 294 in 04a523f
|
pvlib.irradiance.get_total_irradiance
accepts kwargsdni_extra
andairmass
, both default toNone
. However, values for these kwargs are required for several of the irradiance transposition models.See discussion here
Docstring should specify when
dni_extra
andairmass
are required, and which airmass is appropriate for each model.Could also test for kwarg values if e.g.
model=='perez'
The text was updated successfully, but these errors were encountered: