-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update tutorials for pvlib >=0.7 #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was checking "tmy_to_power.ipynb" and found 6 changes are needed to run and there's a deprecation warning.
|
I volunteer to go through and update the notebooks. @cwhanse how do you want to coordinate this with #886? Merge conflicts with notebooks are a bit of a pain to resolve. @steve-ransome ipynb files can be handled through git like normal text files (because they are normal text files) but the diffs can get a little messy because a lot of somewhat irrelevant environment metadata gets captured as well. If you don't want to deal with that, feel free to email me that file and I can do it along with the others: kevin.anderson at nrel.gov
Googling around, nbval is one option. It's a pytest plugin that targets jupyter notebooks and treats each cell like a test. Trying it out on |
Let's hold on a PR to fix the tutorials until after #886 is merged, that's waiting on an approval. If you are willing to do so, we can manually check the tutorials pre-v0.8, see how we like the plugin. |
To compare notebooks, I use nbdime (https://nbdime.readthedocs.io/en/latest/) please give it a try, it's really useful. |
Thanks all, I am willing to help. It would be nice to keep all the tutorials working all the time. Thanks @mikofski , nbdime looks very useful |
Some tutorials e.g.
forecast_to_power.ipynb
use functions that are deprecated, e.g.,pvsystem.sapm_celltemp
.A broader question is how we test and maintain the iPython notebooks to keep up with pvlib changes.
The text was updated successfully, but these errors were encountered: