Skip to content

Commit 1d3b04e

Browse files
test: Strip whitespace when comparing numpy dtypes for 1.22 compat (#3682)
* test: Strip whitespace when comparing numpy dtypes for 1.22 compat Strip whitespace when comparing numpy dtype str() in order to preserve test compatibility with both numpy 1.22 and older versions whose output differ by whitespace. Fixes #3680 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent ffa3468 commit 1d3b04e

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

tests/test_numpy_dtypes.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ def dt_fmt():
3232
e = "<" if byteorder == "little" else ">"
3333
return (
3434
"{{'names':['bool_','uint_','float_','ldbl_'],"
35-
" 'formats':['?','" + e + "u4','" + e + "f4','" + e + "f{}'],"
36-
" 'offsets':[0,4,8,{}], 'itemsize':{}}}"
35+
"'formats':['?','" + e + "u4','" + e + "f4','" + e + "f{}'],"
36+
"'offsets':[0,4,8,{}],'itemsize':{}}}"
3737
)
3838

3939

@@ -46,7 +46,7 @@ def simple_dtype_fmt():
4646
def packed_dtype_fmt():
4747
from sys import byteorder
4848

49-
return "[('bool_', '?'), ('uint_', '{e}u4'), ('float_', '{e}f4'), ('ldbl_', '{e}f{}')]".format(
49+
return "[('bool_','?'),('uint_','{e}u4'),('float_','{e}f4'),('ldbl_','{e}f{}')]".format(
5050
np.dtype("longdouble").itemsize, e="<" if byteorder == "little" else ">"
5151
)
5252

@@ -77,7 +77,7 @@ def partial_nested_fmt():
7777
partial_size = partial_ld_off + ld.itemsize
7878
partial_end_padding = partial_size % np.dtype("uint64").alignment
7979
partial_nested_size = partial_nested_off * 2 + partial_size + partial_end_padding
80-
return "{{'names':['a'], 'formats':[{}], 'offsets':[{}], 'itemsize':{}}}".format(
80+
return "{{'names':['a'],'formats':[{}],'offsets':[{}],'itemsize':{}}}".format(
8181
partial_dtype_fmt(), partial_nested_off, partial_nested_size
8282
)
8383

@@ -123,25 +123,25 @@ def test_dtype(simple_dtype):
123123

124124
e = "<" if byteorder == "little" else ">"
125125

126-
assert m.print_dtypes() == [
126+
assert [x.replace(" ", "") for x in m.print_dtypes()] == [
127127
simple_dtype_fmt(),
128128
packed_dtype_fmt(),
129-
"[('a', {}), ('b', {})]".format(simple_dtype_fmt(), packed_dtype_fmt()),
129+
"[('a',{}),('b',{})]".format(simple_dtype_fmt(), packed_dtype_fmt()),
130130
partial_dtype_fmt(),
131131
partial_nested_fmt(),
132-
"[('a', 'S3'), ('b', 'S3')]",
132+
"[('a','S3'),('b','S3')]",
133133
(
134-
"{{'names':['a','b','c','d'], "
135-
+ "'formats':[('S4', (3,)),('"
134+
"{{'names':['a','b','c','d'],"
135+
+ "'formats':[('S4',(3,)),('"
136136
+ e
137-
+ "i4', (2,)),('u1', (3,)),('"
137+
+ "i4',(2,)),('u1',(3,)),('"
138138
+ e
139-
+ "f4', (4, 2))], "
140-
+ "'offsets':[0,12,20,24], 'itemsize':56}}"
139+
+ "f4',(4,2))],"
140+
+ "'offsets':[0,12,20,24],'itemsize':56}}"
141141
).format(e=e),
142-
"[('e1', '" + e + "i8'), ('e2', 'u1')]",
143-
"[('x', 'i1'), ('y', '" + e + "u8')]",
144-
"[('cflt', '" + e + "c8'), ('cdbl', '" + e + "c16')]",
142+
"[('e1','" + e + "i8'),('e2','u1')]",
143+
"[('x','i1'),('y','" + e + "u8')]",
144+
"[('cflt','" + e + "c8'),('cdbl','" + e + "c16')]",
145145
]
146146

147147
d1 = np.dtype(
@@ -238,15 +238,15 @@ def test_recarray(simple_dtype, packed_dtype):
238238
]
239239

240240
arr = m.create_rec_partial(3)
241-
assert str(arr.dtype) == partial_dtype_fmt()
241+
assert str(arr.dtype).replace(" ", "") == partial_dtype_fmt()
242242
partial_dtype = arr.dtype
243243
assert "" not in arr.dtype.fields
244244
assert partial_dtype.itemsize > simple_dtype.itemsize
245245
assert_equal(arr, elements, simple_dtype)
246246
assert_equal(arr, elements, packed_dtype)
247247

248248
arr = m.create_rec_partial_nested(3)
249-
assert str(arr.dtype) == partial_nested_fmt()
249+
assert str(arr.dtype).replace(" ", "") == partial_nested_fmt()
250250
assert "" not in arr.dtype.fields
251251
assert "" not in arr.dtype.fields["a"][0].fields
252252
assert arr.dtype.itemsize > partial_dtype.itemsize
@@ -285,12 +285,12 @@ def test_array_array():
285285
e = "<" if byteorder == "little" else ">"
286286

287287
arr = m.create_array_array(3)
288-
assert str(arr.dtype) == (
289-
"{{'names':['a','b','c','d'], "
290-
+ "'formats':[('S4', (3,)),('"
288+
assert str(arr.dtype).replace(" ", "") == (
289+
"{{'names':['a','b','c','d'],"
290+
+ "'formats':[('S4',(3,)),('"
291291
+ e
292-
+ "i4', (2,)),('u1', (3,)),('{e}f4', (4, 2))], "
293-
+ "'offsets':[0,12,20,24], 'itemsize':56}}"
292+
+ "i4',(2,)),('u1',(3,)),('{e}f4',(4,2))],"
293+
+ "'offsets':[0,12,20,24],'itemsize':56}}"
294294
).format(e=e)
295295
assert m.print_array_array(arr) == [
296296
"a={{A,B,C,D},{K,L,M,N},{U,V,W,X}},b={0,1},"

0 commit comments

Comments
 (0)