Avoid copy in iteration by using auto &

oleksandr-pavlyk · oleksandr-pavlyk · commit 4d67c6a9e631 · 2023-09-25T02:58:05.000-05:00
This change is fixing a Coverity AUTO_CAUSES_COPY issues.
diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -1142,7 +1142,7 @@ class cpp_function : public function {
                     }
                     msg += "kwargs: ";
                     bool first = true;
-                    for (auto kwarg : kwargs) {
+                    for (auto &kwarg : kwargs) {
                         if (first) {
                             first = false;
                         } else {

Original file line number	Diff line number	Diff line change
`@@ -1142,7 +1142,7 @@ class cpp_function : public function {`
`1142`	`1142`	`}`
`1143`	`1143`	`msg += "kwargs: ";`
`1144`	`1144`	`bool first = true;`
`1145`		`- for (auto kwarg : kwargs) {`
	`1145`	`+ for (auto &kwarg : kwargs) {`
`1146`	`1146`	`if (first) {`
`1147`	`1147`	`first = false;`
`1148`	`1148`	`} else {`