Skip to content

Commit 5cdb8bc

Browse files
committed
Tweaks in response to reviews.
1 parent 7f48837 commit 5cdb8bc

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

docs/upgrade.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ error is raised if the compiler does not meet the requirements:
411411

412412
* GCC >= 4.8
413413
* clang >= 3.3 (appleclang >= 5.0)
414-
* MSVC >= 2017
414+
* MSVC >= 2015u3
415415
* Intel C++ >= 15.0
416416

417417

include/pybind11/detail/common.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -822,9 +822,7 @@ struct is_template_base_of_impl {
822822
/// Check if a template is the base of a type. For example:
823823
/// `is_template_base_of<Base, T>` is true if `struct T : Base<U> {}` where U can be anything
824824
template <template <typename...> class Base, typename T>
825-
#if defined(PYBIND11_CPP20) || !defined(_MSC_VER) \
826-
|| _MSC_VER > 1930 /* Increment as needed, let MS know please. */
827-
// https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
825+
#if defined(PYBIND11_CPP20) || !defined(_MSC_VER) // Sadly, all MSVC versions incl. 2022 need this.
828826
using is_template_base_of
829827
= decltype(is_template_base_of_impl<Base>::check((intrinsic_t<T> *) nullptr));
830828
#else

0 commit comments

Comments
 (0)