Fixing Windows

Author: henryiii

tests/test_operator_overloading.cpp

@@ -62,19 +62,22 @@ namespace std {
     };
 }
 
-#pragma GCC diagnostic push
-// clang 7.0.0 and Apple LLVM 10.0.1 introduce `-Wself-assign-overloaded` to
-// `-Wall`, which is used here for overloading (e.g. `py::self += py::self `).
-// Here, we suppress the warning using `#pragma diagnostic`.
-// Taken from: https://github.com/RobotLocomotion/drake/commit/aaf84b46
-// TODO(eric): This could be resolved using a function / functor (e.g. `py::self()`).
-#if (__APPLE__) && (__clang__)
-  #if (__clang_major__ >= 10) && (__clang_minor__ >= 0) && (__clang_patchlevel__ >= 1)
-    #pragma GCC diagnostic ignored "-Wself-assign-overloaded"
-  #endif
-#elif (__clang__)
-  #if (__clang_major__ >= 7)
-    #pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+// MSVC warns about unknown pragmas, and warnings are errors.
+#ifndef _MSC_VER
+  #pragma GCC diagnostic push
+  // clang 7.0.0 and Apple LLVM 10.0.1 introduce `-Wself-assign-overloaded` to
+  // `-Wall`, which is used here for overloading (e.g. `py::self += py::self `).
+  // Here, we suppress the warning using `#pragma diagnostic`.
+  // Taken from: https://github.com/RobotLocomotion/drake/commit/aaf84b46
+  // TODO(eric): This could be resolved using a function / functor (e.g. `py::self()`).
+  #if (__APPLE__) && (__clang__)
+    #if (__clang_major__ >= 10) && (__clang_minor__ >= 0) && (__clang_patchlevel__ >= 1)
+      #pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+    #endif
+  #elif (__clang__)
+    #if (__clang_major__ >= 7)
+      #pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+    #endif
   #endif
 #endif
 
@@ -161,4 +164,6 @@ TEST_SUBMODULE(operators, m) {
     m.def("get_NestC", [](const NestC &c) { return c.value; });
 }
 
-#pragma GCC diagnostic pop
+#ifndef _MSC_VER
+  #pragma GCC diagnostic pop
+#endif