Fix a clang-tidy issue: do not use 'else' after 'return'

Amir · Amir · commit 8c6612794fab · 2022-12-04T23:41:30.000+02:00
diff --git a/include/pybind11/detail/type_caster_base.h b/include/pybind11/detail/type_caster_base.h
@@ -1011,9 +1011,8 @@ PYBIND11_NOINLINE std::string type_info_description(const std::type_info &ti) {
         handle th((PyObject *) type_data->type);
         return th.attr("__module__").cast<std::string>() + '.'
                + th.attr("__qualname__").cast<std::string>();
-    } else {
-        return clean_type_id(ti.name());
     }
+    return clean_type_id(ti.name());
 }
 
 PYBIND11_NAMESPACE_END(detail)

Original file line number	Diff line number	Diff line change
`@@ -1011,9 +1011,8 @@ PYBIND11_NOINLINE std::string type_info_description(const std::type_info &ti) {`
`1011`	`1011`	`handle th((PyObject *) type_data->type);`
`1012`	`1012`	`return th.attr("__module__").cast<std::string>() + '.'`
`1013`	`1013`	`+ th.attr("__qualname__").cast<std::string>();`
`1014`		`- } else {`
`1015`		`- return clean_type_id(ti.name());`
`1016`	`1014`	`}`
	`1015`	`+ return clean_type_id(ti.name());`
`1017`	`1016`	`}`
`1018`	`1017`
`1019`	`1018`	`PYBIND11_NAMESPACE_END(detail)`