Semi-paranoid placement new (based on #4877 (comment)).

rwgk · rwgk · commit a864f2123cc8 · 2023-10-09T10:36:16.000-07:00
diff --git a/include/pybind11/numpy.h b/include/pybind11/numpy.h
@@ -66,7 +66,7 @@ class LazyInitializeAtLeastOnceDestroyNever {
             assert(PyGILState_Check());
             auto value = initialize();
             if (!initialized_) {
-                new (reinterpret_cast<T *>(value_storage_)) T(std::move(value));
+                ::new (value_storage_) T(std::move(value));
                 initialized_ = true;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ class LazyInitializeAtLeastOnceDestroyNever {`
`66`	`66`	`assert(PyGILState_Check());`
`67`	`67`	`auto value = initialize();`
`68`	`68`	`if (!initialized_) {`
`69`		`- new (reinterpret_cast<T *>(value_storage_)) T(std::move(value));`
	`69`	`+ ::new (value_storage_) T(std::move(value));`
`70`	`70`	`initialized_ = true;`
`71`	`71`	`}`
`72`	`72`	`}`