Skip to content

Commit bec4e6d

Browse files
committed
Removing PYBIND11_NOINLINE_FORCED (to be moved to an alternative PR).
1 parent af0d4ca commit bec4e6d

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

include/pybind11/detail/common.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -96,16 +96,6 @@
9696
# endif
9797
#endif
9898

99-
// For CUDA, GCC7, GCC8 (and maybe some other platforms):
100-
// PYBIND11_NOINLINE_FORCED is incompatible with `-Wattributes -Werror`.
101-
// When defining PYBIND11_NOINLINE_FORCED, it is best to also use
102-
// `-Wno-attributes` (or not to use `-Werror` and ignore the warnings).
103-
#if !defined(PYBIND11_NOINLINE_FORCED) && \
104-
(defined(__CUDACC__) || \
105-
(defined(__GNUC__) && (__GNUC__ == 7 || __GNUC__ == 8)))
106-
# define PYBIND11_NOINLINE_DISABLED
107-
#endif
108-
10999
// The PYBIND11_NOINLINE macro is for function DEFINITIONS.
110100
// In contrast, FORWARD DECLARATIONS should never use this macro:
111101
// https://stackoverflow.com/questions/9317473/forward-declaration-of-inline-functions
@@ -117,11 +107,6 @@
117107
# define PYBIND11_NOINLINE __attribute__ ((noinline)) inline
118108
#endif
119109

120-
// DECISION TO BE MADE before this PR is merged:
121-
// ----------------------------------------------------------------------------
122-
// This code and the 9 x 2 pragma blocks referring to
123-
// PYBIND11_NOINLINE_GCC_PRAGMA_ATTRIBUTES_NEEDED could be purged.
124-
// ----------------------------------------------------------------------------
125110
#if !defined(PYBIND11_NOINLINE_DISABLED)
126111
# if (defined(__CUDACC__) || (defined(__GNUC__) && (__GNUC__ == 7 || __GNUC__ == 8))) \
127112
&& !defined(PYBIND11_NOINLINE_GCC_PRAGMA_ATTRIBUTES_NEEDED)

0 commit comments

Comments
 (0)