Reapply minor fix that accidentally got lost in transfer from PR #3964

rwgk · rwgk · commit dbbe9d1cb3dd · 2022-05-28T12:04:09.000-07:00
diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -1177,7 +1177,7 @@ class module_ : public object {
         if (this_name == nullptr) {
             throw error_already_set();
         }
-        std::string full_name = std::string(this_name) + "." + name;
+        std::string full_name = std::string(this_name) + '.' + name;
         handle submodule = PyImport_AddModule(full_name.c_str());
         if (!submodule) {
             throw error_already_set();

Original file line number	Diff line number	Diff line change
`@@ -1177,7 +1177,7 @@ class module_ : public object {`
`1177`	`1177`	`if (this_name == nullptr) {`
`1178`	`1178`	`throw error_already_set();`
`1179`	`1179`	`}`
`1180`		`- std::string full_name = std::string(this_name) + "." + name;`
	`1180`	`+ std::string full_name = std::string(this_name) + '.' + name;`
`1181`	`1181`	`handle submodule = PyImport_AddModule(full_name.c_str());`
`1182`	`1182`	`if (!submodule) {`
`1183`	`1183`	`throw error_already_set();`