fix(smart_holder): Use std::default_delete. (#4924)

iwanders · web-flow · commit e02fe001cdb9 · 2023-11-06T15:56:21.000-08:00
Ensures `std::default_delete&lt;T&gt;` is used to look up the deleter for a type instead of `delete` directly.
diff --git a/include/pybind11/detail/smart_holder_poc.h b/include/pybind11/detail/smart_holder_poc.h
@@ -103,7 +103,7 @@ struct guarded_delete {
 
 template <typename T, typename std::enable_if<std::is_destructible<T>::value, int>::type = 0>
 inline void builtin_delete_if_destructible(void *raw_ptr) {
-    delete static_cast<T *>(raw_ptr);
+    std::default_delete<T>{}(static_cast<T *>(raw_ptr));
 }
 
 template <typename T, typename std::enable_if<!std::is_destructible<T>::value, int>::type = 0>

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ struct guarded_delete {`
`103`	`103`
`104`	`104`	`template <typename T, typename std::enable_if<std::is_destructible<T>::value, int>::type = 0>`
`105`	`105`	`inline void builtin_delete_if_destructible(void *raw_ptr) {`
`106`		`- delete static_cast<T *>(raw_ptr);`
	`106`	`+ std::default_delete<T>{}(static_cast<T *>(raw_ptr));`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`template <typename T, typename std::enable_if<!std::is_destructible<T>::value, int>::type = 0>`