Removing MSVC C4996 from pragma block at the top of pybind11.h

Author: rwgk

include/pybind11/chrono.h

@@ -164,7 +164,14 @@ template <typename Duration> class type_caster<std::chrono::time_point<std::chro
 
         // std::localtime returns a pointer to a static internal std::tm object on success,
         // or null pointer otherwise
+#if defined(_MSC_VER)
+#    pragma warning(push)
+#    pragma warning(disable : 4996) // warning C4996: The POSIX name for this item is deprecated.
+#endif
         std::tm *localtime_ptr = std::localtime(&tt);
+#if defined(_MSC_VER)
+#    pragma warning(pop)
+#endif
         if (!localtime_ptr)
             throw cast_error("Unable to represent system_clock in local time");
 

include/pybind11/pybind11.h

@@ -19,7 +19,6 @@
 #  pragma warning(disable: 4100) // warning C4100: Unreferenced formal parameter
 #  pragma warning(disable: 4127) // warning C4127: Conditional expression is constant
 #  pragma warning(disable: 4800) // warning C4800: 'int': forcing value to bool 'true' or 'false' (performance warning)
-#  pragma warning(disable: 4996) // warning C4996: The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name
 #  pragma warning(disable: 4522) // warning C4522: multiple assignment operators specified
 #  pragma warning(disable: 4505) // warning C4505: 'PySlice_GetIndicesEx': unreferenced local function has been removed (PyPy only)
 #elif defined(__GNUG__) && !defined(__clang__)
@@ -43,6 +42,8 @@
 #include <string>
 #include <utility>
 
+#include <string.h>
+
 #if defined(__cpp_lib_launder) && !(defined(_MSC_VER) && (_MSC_VER < 1914))
 #  define PYBIND11_STD_LAUNDER std::launder
 #  define PYBIND11_HAS_STD_LAUNDER 1
@@ -76,8 +77,18 @@ inline bool apply_exception_translators(std::forward_list<ExceptionTranslator>&
     return false;
 }
 
-PYBIND11_NAMESPACE_END(detail)
+#if defined(_MSC_VER)
+#    pragma warning(push)
+#    pragma warning(disable : 4996) // warning C4996: The POSIX name for this item is deprecated.
+#endif
+
+inline char *strdup_helper(const char *s) { return strdup(s); }
 
+#if defined(_MSC_VER)
+#    pragma warning(pop)
+#endif
+
+PYBIND11_NAMESPACE_END(detail)
 
 /// Wraps an arbitrary C++ function/method/lambda function/.. into a callable Python object
 class cpp_function : public function {
@@ -276,7 +287,7 @@ class cpp_function : public function {
                 std::free(s);
         }
         char *operator()(const char *s) {
-            auto t = strdup(s);
+            auto t = detail::strdup_helper(s);
             strings.push_back(t);
             return t;
         }
@@ -520,7 +531,8 @@ class cpp_function : public function {
         auto *func = (PyCFunctionObject *) m_ptr;
         std::free(const_cast<char *>(func->m_ml->ml_doc));
         // Install docstring if it's non-empty (when at least one option is enabled)
-        func->m_ml->ml_doc = signatures.empty() ? nullptr : strdup(signatures.c_str());
+        func->m_ml->ml_doc
+            = signatures.empty() ? nullptr : detail::strdup_helper(signatures.c_str());
 
         if (rec->is_method) {
             m_ptr = PYBIND11_INSTANCE_METHOD_NEW(m_ptr, rec->scope.ptr());
@@ -1525,15 +1537,15 @@ class class_ : public detail::generic_type {
            detail::process_attributes<Extra...>::init(extra..., rec_fget);
            if (rec_fget->doc && rec_fget->doc != doc_prev) {
               free(doc_prev);
-              rec_fget->doc = strdup(rec_fget->doc);
+              rec_fget->doc = detail::strdup_helper(rec_fget->doc);
            }
         }
         if (rec_fset) {
             char *doc_prev = rec_fset->doc;
             detail::process_attributes<Extra...>::init(extra..., rec_fset);
             if (rec_fset->doc && rec_fset->doc != doc_prev) {
                 free(doc_prev);
-                rec_fset->doc = strdup(rec_fset->doc);
+                rec_fset->doc = detail::strdup_helper(rec_fset->doc);
             }
             if (! rec_active) rec_active = rec_fset;
         }