fix: run clang-tidy action locally and fix remaining issues

Author: henryiii

include/pybind11/pytypes.h

@@ -1605,8 +1605,8 @@ class capsule : public object {
             pybind11_fail("Could not allocate capsule object!");
     }
 
-    // NOLINTNEXTLINE(google-explicit-constructor)
     template <typename T>
+    // NOLINTNEXTLINE(google-explicit-constructor)
     operator T *() const {
         return get_pointer<T>();
     }

tests/test_numpy_dtypes.cpp

@@ -160,7 +160,7 @@ template <typename S>
 py::array_t<S, 0> create_recarray(size_t n) {
     auto arr = mkarray_via_buffer<S>(n);
     auto req = arr.request();
-    auto ptr = static_cast<S *>(req.ptr);
+    auto *ptr = static_cast<S *>(req.ptr);
     for (size_t i = 0; i < n; i++) {
         SET_TEST_VALS(ptr[i], i);
     }
@@ -170,7 +170,7 @@ py::array_t<S, 0> create_recarray(size_t n) {
 template <typename S>
 py::list print_recarray(py::array_t<S, 0> arr) {
     const auto req = arr.request();
-    const auto ptr = static_cast<S *>(req.ptr);
+    const auto *ptr = static_cast<S *>(req.ptr);
     auto l = py::list();
     for (py::ssize_t i = 0; i < req.size; i++) {
         std::stringstream ss;

tests/test_stl.cpp

@@ -395,9 +395,9 @@ TEST_SUBMODULE(stl, m) {
     m.def("half_or_none_refsensitive", [](int x) -> refsensitive_opt_int {
         return x != 0 ? refsensitive_opt_int(x / 2) : refsensitive_opt_int();
     });
-    // NOLINTNEXTLINE(performance-unnecessary-value-param)
     m.def(
         "test_nullopt_refsensitive",
+        // NOLINTNEXTLINE(performance-unnecessary-value-param)
         [](refsensitive_opt_int x) { return x ? x.value() : 42; },
         py::arg_v("x", refsensitive_opt_int(), "None"));
     m.def(

tests/test_stl_binders.cpp

@@ -43,23 +43,23 @@ class E_nc {
 
 template <class Container>
 Container *one_to_n(int n) {
-    auto v = new Container();
+    auto *v = new Container();
     for (int i = 1; i <= n; i++)
         v->emplace_back(i);
     return v;
 }
 
 template <class Map>
 Map *times_ten(int n) {
-    auto m = new Map();
+    auto *m = new Map();
     for (int i = 1; i <= n; i++)
         m->emplace(int(i), E_nc(10 * i));
     return m;
 }
 
 template <class NestMap>
 NestMap *times_hundred(int n) {
-    auto m = new NestMap();
+    auto *m = new NestMap();
     for (int i = 1; i <= n; i++)
         for (int j = 1; j <= n; j++)
             (*m)[i].emplace(int(j * 10), E_nc(100 * j));