Move is_finalizing() back to pybind11.h

Author: malfet

include/pybind11/detail/common.h

@@ -695,19 +695,6 @@ using expand_side_effects = bool[];
 #define PYBIND11_EXPAND_SIDE_EFFECTS(PATTERN) (void)pybind11::detail::expand_side_effects{ ((PATTERN), void(), false)..., false }
 #endif
 
-// Thread state manipulation C API should not be called while Python runtime is finalizing.
-// For more detail see https://docs.python.org/3.7/c-api/init.html#c.PyEval_RestoreThread
-// `is_finalizing()` provides a version agnostic way to check if runtime is finalizing.
-inline bool is_finalizing() {
-#if PY_MAJOR_VERSION < 3
-    return false;
-#elif PY_VERSION_HEX >= 0x03070000
-    return _Py_IsFinalizing();
-#else
-    return _Py_Finalizing;
-#endif
-}
-
 PYBIND11_NAMESPACE_END(detail)
 
 /// C++ bindings of builtin Python exceptions

include/pybind11/pybind11.h

@@ -1168,6 +1168,19 @@ inline void add_class_method(object& cls, const char *name_, const cpp_function
     }
 }
 
+// Thread state manipulation C API should not be called while Python runtime is finalizing.
+// For more detail see https://docs.python.org/3.7/c-api/init.html#c.PyEval_RestoreThread
+// `is_finalizing()` provides a version agnostic way to check if runtime is finalizing.
+inline bool is_finalizing() {
+#if PY_MAJOR_VERSION < 3
+    return false;
+#elif PY_VERSION_HEX >= 0x03070000
+    return _Py_IsFinalizing();
+#else
+    return _Py_Finalizing;
+#endif
+}
+
 PYBIND11_NAMESPACE_END(detail)
 
 /// Given a pointer to a member function, cast it to its `Derived` version.