We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.10.2
In 2.10.2, @rwgk added a really neat feature to detect undefined behavior by double checking the GIL on reference counter calls.
Unfortunately (as experienced by our users, scipy/scipy#17644), the error messages here are really bad, especially on Windows.
We need a better error message strategy here to avoid user confusion.
This is tricky because this feels like a regression to our users when we really want to better inform them about UB in their code.
https://github.com/tylerjereddy/pybind_repro is a really nice Windows example that has terrible error messaging.
2.10.1
The text was updated successfully, but these errors were encountered:
I'll assign myself as I already have pybind_repro set up on Windows so I can easily play with different error reporting strategies.
One key thing is that we must not throw exceptions in the DLL load process. We probably want to do some raw printf calls here.
Sorry, something went wrong.
Similar issues here as well: pytorch/pytorch#91251 Not sure if it's the exact same cause, but there is no good stack trace to follow either.
Successfully merging a pull request may close this issue.
Required prerequisites
What version (or hash if on master) of pybind11 are you using?
2.10.2
Problem description
In 2.10.2, @rwgk added a really neat feature to detect undefined behavior by double checking the GIL on reference counter calls.
Unfortunately (as experienced by our users, scipy/scipy#17644), the error messages here are really bad, especially on Windows.
We need a better error message strategy here to avoid user confusion.
This is tricky because this feels like a regression to our users when we really want to better inform them about UB in their code.
Reproducible example code
https://github.com/tylerjereddy/pybind_repro is a really nice Windows example that has terrible error messaging.
Is this a regression? Put the last known working version here if it is.
2.10.1
The text was updated successfully, but these errors were encountered: