From 3509fc01b979cda40d75b3e30b985962c52aad0c Mon Sep 17 00:00:00 2001 From: Ethan Steinberg Date: Wed, 28 Dec 2022 09:58:46 -0800 Subject: [PATCH 1/2] Revert the GIL check --- include/pybind11/detail/common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/pybind11/detail/common.h b/include/pybind11/detail/common.h index 068ae0137a..2cf5a44c68 100644 --- a/include/pybind11/detail/common.h +++ b/include/pybind11/detail/common.h @@ -329,7 +329,8 @@ PYBIND11_WARNING_POP && defined(_MSC_VER)) /* PyPy Windows: pytest hangs indefinitely at the end of the \ process (see PR #4268) */ \ && !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF) -# define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF +// TODO: Actually enable the following define in the 2.11 release +// define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF #endif // #define PYBIND11_STR_LEGACY_PERMISSIVE From 8cbae86ba35469c644c81bcf82fa04c93fb7b002 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Fri, 30 Dec 2022 09:22:32 -0500 Subject: [PATCH 2/2] Update include/pybind11/detail/common.h --- include/pybind11/detail/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pybind11/detail/common.h b/include/pybind11/detail/common.h index 2cf5a44c68..62bf521fb9 100644 --- a/include/pybind11/detail/common.h +++ b/include/pybind11/detail/common.h @@ -329,7 +329,7 @@ PYBIND11_WARNING_POP && defined(_MSC_VER)) /* PyPy Windows: pytest hangs indefinitely at the end of the \ process (see PR #4268) */ \ && !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF) -// TODO: Actually enable the following define in the 2.11 release +// The following define will be enabled by default in the 2.11 release // define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF #endif