Skip to content

Commit 39b5b16

Browse files
authored
Merge pull request #475 from bashtage/morningstar-bug-column-order
BUG: Fix order of columns in morningstar
2 parents 9e9d63c + b657e30 commit 39b5b16

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

pandas_datareader/mstar/daily.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,8 @@ def _restruct_json(self, symbol, jsondata):
172172
bar = pricedata[p]
173173
d = next(date_)
174174
bardict = {
175-
"Symbol": symbol, "Date": d, "Open": bar[0], "High": bar[1],
176-
"Low": bar[2],
177-
"Close": bar[3]
175+
"Symbol": symbol, "Date": d, "Close": bar[0], "High": bar[1],
176+
"Low": bar[2], "Open": bar[3]
178177
}
179178
if len(divdata) == 0:
180179
pass

pandas_datareader/tests/mstar/test_daily.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_mstar(self):
3838
start = datetime(2014, 3, 5)
3939
end = datetime(2018, 1, 18)
4040
df = web.DataReader('MSFT', 'morningstar', start=start, end=end)
41-
assert (df['Close'][-1] == 89.8)
41+
assert (df['Open'][-1] == 89.8)
4242

4343
@skip_on_exception(RemoteDataError)
4444
def test_get_data_single_symbol(self):
@@ -114,7 +114,7 @@ def test_mstar_reader_class(self):
114114
dr = MorningstarDailyReader(symbols="GOOG", interval="d")
115115
df = dr.read()
116116

117-
assert df.Volume[('GOOG', '2017-12-13')] == 1279659
117+
assert df.Close[('GOOG', '2017-12-13')] == 1040.61
118118

119119
session = requests.Session()
120120

0 commit comments

Comments
 (0)