Skip to content

Google Quote shouldn't return a DataFrame and should be documented #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
femtotrader opened this issue Feb 28, 2016 · 4 comments
Closed

Google Quote shouldn't return a DataFrame and should be documented #184

femtotrader opened this issue Feb 28, 2016 · 4 comments

Comments

@femtotrader
Copy link
Contributor

Hello,

In [3]: pdr.get_quote_google(['MSFT', 'F'])
Out[3]:
          0
MSFT  51.30
F     12.47

Google Quote shouldn't return a DataFrame but either a Series or a dict

Moreover some doc is necessary.

Pinging @gliptak

Kind regards
@femtotrader femtotrader mentioned this issue Feb 28, 2016
Merged
@femtotrader
Copy link
Contributor Author

GoogleQuotesReader should also be available through DataReader function

maybe we should use google-quote as data_source

@gliptak gliptak mentioned this issue Mar 2, 2016
Merged
@gliptak
Copy link
Contributor

gliptak commented Mar 6, 2016

@femtotrader Added docs with #188

@gliptak
Copy link
Contributor

gliptak commented Mar 12, 2016

Implemented.

@femtotrader
Copy link
Contributor Author

Thanks @gliptak for this also.
I'm closing this issue as your PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gliptak @femtotrader