Retrieving Fama-French results in HTTP 404 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sinhrks opened this issue Jul 15, 2015 · 1 comment

Member

sinhrks commented Jul 15, 2015

Not look into detail because I'm out, filenames seem to be changed. It fails in current pandas master also. See pandas-dev/pandas#10591.

http://mba.tuck.dartmouth.edu/pages/faculty/ken.french/data_library.html

Member Author

sinhrks commented Jul 15, 2015

Changing the following line as below should work. I'll send a PR later.

https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/data.py#L589

    zip_file_path = '{0}/{1}_TXT.zip'.format(_FAMAFRENCH_URL, name)

sinhrks mentioned this issue

API: Update Fama-French url #53

Merged

bashtage closed this as completed in #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment