Skip to content

Timeout not actually used #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JesseAldridge opened this issue Jun 16, 2020 · 0 comments · Fixed by #790
Closed

Timeout not actually used #789

JesseAldridge opened this issue Jun 16, 2020 · 0 comments · Fixed by #790

Comments

@JesseAldridge
Copy link
Contributor

I noticed my downloader hung forever. I dug through the code and it looks like the timeout parameter isn't actually passed the request call.

pandas-datareader/pandas_datareader/base.py

Line 142 in 09ab475

response = self.session.get(url, params=params, headers=headers)

Pretty sure the fix is just:

- response = self.session.get(url, params=params, headers=headers)
+ response = self.session.get(url, params=params, headers=headers, timeout=self.timeout)
@JesseAldridge JesseAldridge mentioned this issue Jun 18, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add timeout JesseAldridge/pandas-datareader
1 participant
@JesseAldridge