remove label

Author: gabalafou

src/pydata_sphinx_theme/assets/styles/components/_search.scss

@@ -37,10 +37,6 @@
     color: var(--pst-color-text-muted);
   }
 
-  label {
-    display: flex;
-  }
-
   input.form-control {
     background-color: var(--pst-color-background);
     color: var(--pst-color-text-base);

src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/search-field.html

@@ -2,13 +2,12 @@
 <form class="bd-search d-flex align-items-center"
       action="{{ pathto('search') }}"
       method="get">
-  <label for="{{ search_input_id }}"
-         aria-label="{{ theme_search_bar_text }}"><i class="fa-solid fa-magnifying-glass"></i></label>
+  <i class="fa-solid fa-magnifying-glass"></i>
   <input type="search"
          class="form-control"
          name="q"
-         id="{{ search_input_id }}"
          placeholder="{{ theme_search_bar_text }}"
+         aria-label="{{ theme_search_bar_text }}"
          autocomplete="off"
          autocorrect="off"
          autocapitalize="off"

src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html

@@ -64,7 +64,6 @@
   <label class="overlay overlay-secondary" for="pst-secondary-sidebar-checkbox"></label>
   {# A search field pop-up that will only show when the search button is clicked #}
   <dialog class="search-button__search-container">
-    {%- set search_input_id="search-input-hidden" -%}
     {% include "../components/search-field.html" %}
   </dialog>
 

src/pydata_sphinx_theme/theme/pydata_sphinx_theme/search.html

@@ -9,7 +9,6 @@ <h1>{{ _("Search") }}</h1>
         <p>{% trans %}Please activate JavaScript to enable the search functionality.{% endtrans %}</p>
       </div>
     </noscript>
-    {%- set search_input_id="search-input-results-page" -%}
     {% include "../components/search-field.html" %}
     <div id="search-results"></div>
   </div>