Add deprecation warning for html_logo

Author: choldgraf

src/pydata_sphinx_theme/__init__.py

@@ -29,8 +29,14 @@
 logger = logging.getLogger(__name__)
 
 
-def update_config(app):
+def update_config_deprecations(app):
+    """Update deprecated config values and raise warnings.
+
+    Each section should contain a comment describing which release
+    to remove the deprecated value entirely.
+    """
     theme_options = app.config.html_theme_options
+    config = app.config
 
     # DEPRECATE >= v0.10
     if theme_options.get("search_bar_position") == "navbar":
@@ -43,27 +49,41 @@ def update_config(app):
     if theme_options.get("left_sidebar_end"):
         theme_options["primary_sidebar_end"] = theme_options.get("left_sidebar_end")
         logger.warning(
-            "The configuration `left_sidebar_end` is deprecated."
+            "The configuration `left_sidebar_end` is deprecated. "
             "Use `primary_sidebar_end`"
         )
 
+    # DEPRECATE >= 0.13
     if theme_options.get("logo_text"):
         logo = theme_options.get("logo", {})
         logo["text"] = theme_options.get("logo_text")
         theme_options["logo"] = logo
         logger.warning(
-            "The configuration `logo_text` is deprecated." "Use `'logo': {'text': }`."
+            "The configuration `logo_text` is deprecated. " "Use `'logo': {'text': }`."
         )
 
+    # DEPRECATE >= 0.13
     if theme_options.get("page_sidebar_items"):
         theme_options["secondary_sidebar_items"] = theme_options.get(
             "page_sidebar_items"
         )
         logger.warning(
-            "The configuration `page_sidebar_items` is deprecated."
+            "The configuration `page_sidebar_items` is deprecated. "
             "Use `secondary_sidebar_items`."
         )
 
+    # DEPRECATE >= 0.14
+    if hasattr(config, "html_logo"):
+        config.__dict__["html_logo_url"] = config.html_logo
+        logger.warning(
+            "Config value `html_logo` is deprecated. " "Use `html_logo_url` instead."
+        )
+
+
+def update_config(app):
+    """Update configuration values with defaults and validation."""
+    theme_options = app.config.html_theme_options
+
     # Validate icon links
     if not isinstance(theme_options.get("icon_links", []), list):
         raise ExtensionError(
@@ -1048,6 +1068,7 @@ def setup(app):
     app.set_translator("readthedocs", BootstrapHTML5Translator, override=True)
     app.set_translator("readthedocsdirhtml", BootstrapHTML5Translator, override=True)
 
+    app.connect("builder-inited", update_config_deprecations)
     app.connect("builder-inited", update_config)
     app.connect("html-page-context", setup_edit_url)
     app.connect("html-page-context", add_toctree_functions)