MAINT - Purge codecov (#1809)

Co-authored-by: Tania Allard <[email protected]>

Author: drammock

.github/workflows/tests.yml

@@ -101,14 +101,6 @@ jobs:
         with:
           name: coverage-${{ matrix.python-version }}-${{ matrix.os }}-${{ matrix.sphinx-version }}
           path: .coverage.${{ matrix.python-version }}.${{ matrix.os }}.${{ matrix.sphinx-version }}
-      - name: Upload to Codecov
-        if: matrix.python-version == '3.12' && matrix.os == 'ubuntu-latest' && matrix.sphinx-version == 'dev'
-        uses: codecov/codecov-action@v4
-        with:
-          fail_ci_if_error: true
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-
       # note I am setting this on top of the Python cache as I could not find
       # how to set the hash key on the python one
       - name: Set up browser cache (for accessibility tests)
@@ -131,7 +123,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: run-pytest
     # run both on previous step success and failure
-    if: "!cancelled()"
+    if: ${{ !cancelled() }}
     permissions:
       pull-requests: write
       contents: write