Skip to content

Commit 933ce14

Browse files
authored
Import Bootstrap after importing our variable overrides (#2066)
This PR restores the effects of the variables defined in [variables/_bootstrap.scss](https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/styles/variables/_bootstrap.scss) This fixes #2022 and also fixes another issue that I had noticed when clicking links in the "More" dropdown. Screenshots: - Fixed: ![](https://github.com/user-attachments/assets/060fa3fe-2ce8-4311-b127-7821ddbbdadc) - Broken: ![](https://github.com/user-attachments/assets/f1de59b9-e6a6-485f-8e83-22a3548de94f)
1 parent 6cc8ddf commit 933ce14

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/pydata_sphinx_theme/assets/styles/pydata-sphinx-theme.scss

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
// Import all of Bootstrap scss
1+
// IMPORTANT: our Bootstrap variable overrides must be imported before the
2+
// Bootstrap files that reference those variables; otherwise our overrides will
3+
// have no effect.
4+
@import "variables/bootstrap";
5+
6+
// Import all of Bootstrap scss.
27
@import "~bootstrap/scss/bootstrap";
38

49
// Import FontAwesome from _node_modules
@@ -8,7 +13,6 @@
813
@import "~@fortawesome/fontawesome-free/scss/brands";
914

1015
// Variables
11-
@import "variables/bootstrap";
1216
@import "variables/layout";
1317
@import "variables/fonts";
1418
@import "variables/icons";

0 commit comments

Comments
 (0)