Size of the logo in the top navbar

[jorisvandenbossche]

The dev docs of pandas are back online, so we can compare the one with the latest version of the theme, and the released one, and I noticed the size of the logo changed.

Latest: https://pandas.pydata.org/docs/dev/user_guide/indexing.html#setting-with-enlargement

Stable: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html

As I mentioned before, this might be due to the pandas logo file containing too much whitespace (see https://pandas.pydata.org/docs/dev/_static/pandas.svg)

[betatim]

For https://binderhub.readthedocs.io/en/latest/ I see the same. The build currently at https://binderhub.readthedocs.io/en/latest/ is "old".

If I build the docs locally with v0.2.1

If I build the docs locally with v0.1.1 of this theme I get the following;

Our logo file hasn't changed between the two builds so I don't think that is the reason.

Is the change of the position of the text items in the navbar related/on purpose? They used to start right after the logo but now start where the sidebar ends. (New issue?)

[choldgraf]

I think this is an "intended" regression based off of some bootstrap refactoring that was done. At the time, I believe we agreed to wait and see whether the new header offset would bug people. IMO it does bug people and we should make the top headers come just after the logo.

[jorisvandenbossche]

That's not related to the size of the logo, though. So let's open a separate issue for that.

[choldgraf]

good point - opened in #163 @betatim would be great to have your thoughts on that particular issue over there

[choldgraf]

if I remove the padding from the brand link, then it seems to be roughly the same size. e.g,. adding:

a.navbar-brand {
    padding: 0;
}

changes it to this:

old behavior for comparison:

I think those are pretty close

[12rambau]

We are about to release v0.9 and the padding of the navbar-brand is still .5rem 0. Is it still a wanted feature ?

[choldgraf]

I'm not sure - but my feeling is that we should make the logo look nice w CSS rules that assume the logo stretches all the way to the border of the SVG or PNG. So we should define a logo to test with (maybe the pandas logo until we define one for this theme?) And make it look properly padded with CSS rules then go with that

[12rambau]

Hop we now have our own logo:

To be fair, I like it. I'm not sure we should change anything.

[choldgraf]

It looks good to me, I'd be happy to close