Why is @import "variables/bootstrap"; imported twice?

[jarrodmillman]

Why is @import "variables/bootstrap"; in both

• https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/styles/bootstrap.scss
• https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/styles/pydata-sphinx-theme.scss

[12rambau]

Initially everything was in pydata-sphinx-theme.scss I guess when I created bootstrap.scss I forgot to remove it from the other file.
I'm not completely fluent in scss so better check if variables should be imported in both (as both files are using these custom variables that overwrite default bootstrap).

[trallard]

I do not think we need a double import per the hierarchy we follow (https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/styles/pydata-sphinx-theme.scss?rgh-link-date=2024-04-26T02%3A13%3A11Z has all the scss imports we need)

@gabalafou do you have any insights?

[gabalafou]

Not an expert, but my guess is that the file needs to be imported in both places since bootstrap.scss and pydata-sphinx-theme.scss go to different build targets

[trallard]

As I started looking into our whole webpack configuration and vendoring I thought I would update here.

It seems it is like mentioned above probably an oversight/ leftover from previous interations. And we only need importing once.
I shall be opening a PR addressing this as well as other webpack improvements (that should also help with performance improvements).