-
Notifications
You must be signed in to change notification settings - Fork 339
Indent our admonitions a bit more #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, I had the same "first impression" when seeing the admonitioins in the actual pandas docs. We should probably add a bit more margin around the text in the admonitions. Fully agreed! I think there can be more whitespace in all margins, not only the left |
Looks much better I think! I would personally still do a little bit more vertical space at the bottom as well. |
Merged
see #207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that many other nice-looking documentation sites have an obvious indentation level between their admonition text and the text in the rest of the document.
e.g.:
netlify:
metaflow:
And a comparison from the sphinx-book-theme for example:
This makes me think two things:
Do others think it would be useful to try adding a bit more whitespace to admonition blocks, and in particular on the left margin?
The text was updated successfully, but these errors were encountered: