Skip to content

Issue release that includes PR 224 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathancarter opened this issue Aug 28, 2020 · 10 comments
Closed

Issue release that includes PR 224 #238

nathancarter opened this issue Aug 28, 2020 · 10 comments

Comments

@nathancarter
Copy link

This issue is merely to request a new release that includes the recent bug fix of font problems that happened in #224.

I have an online book going live for incoming students this coming week, so if that release happened, I could make sure the text looked correctly before they began using it.

See also jupyter-book/jupyter-book#751.

Thank you!

@choldgraf
Copy link
Collaborator

@jorisvandenbossche any reason not to cut a new release?

@jorisvandenbossche
Copy link
Member

I actually did one today (for numpy) -> https://github.com/pandas-dev/pydata-sphinx-theme/releases/tag/v0.3.2, but that only included two small (and safe I think) bug fixes.

My idea was to do a new 0.4 release once #190 is in (I have been actively working on the last week), because that requires a major release I think.
But can of course also cut master as 0.4, and then include #190 in 0.5.
No problem, releasing is not much work!

@choldgraf
Copy link
Collaborator

choldgraf commented Aug 28, 2020

@nathancarter do you mind waiting a few days before we issue a release so we can get #190 in as well? @jorisvandenbossche are you thinking to have this done soon? I think that if #190 will be in within, say, 3-7 days then we should just wait, and if not then we can cut a new release now.

@nathancarter
Copy link
Author

Well, my request is not exactly an emergency. :)

But I'm aiming to start sharing my work to students on 9/3/2020, so if it's before then, that'd be great.

@choldgraf
Copy link
Collaborator

@nathancarter sounds good - if we don't make it by that time, perhaps you can mention that there's a known bug and share a link to the issue in case you wanna make it a teachable moment about how open source works :-)

@jorisvandenbossche
Copy link
Member

If I don't make it to finish #190 the coming days, I can certainly cut a release from master, no problem!

@jorisvandenbossche
Copy link
Member

I was thinking: even if I finish #190 the coming days, ideally we let it sit a couple of days extra in master. So let me just quickly cut a 0.4 release from master now! ;)

@jorisvandenbossche
Copy link
Member

I had a small complication with the black linting that was still failing (and then the workflow to push to pypi is not run). But released now!

@jorisvandenbossche
Copy link
Member

@nathancarter
Copy link
Author

Awesome, I just upgraded and got bold fonts in my built HTML. Thanks very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants