-
Notifications
You must be signed in to change notification settings - Fork 339
pydata-sphinx-theme 0.8.1 requires sphinx<5,>=3.5.4 #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you need to keep the upper bound for some reason that I am not aware of, maybe you could atleast make a prerelease that doesn't have the upper bound. That would make the CI configuration more consistent for numpydoc. Or maybe there is a pip flag that I can use to ignore the upper bound... |
Related issues and PRs: |
I think you may use |
I recommend against using the Here is what I would do assuming you decide not to "officially" support sphinx 5:
Here is what you will need to do (if you use the
Is there a reason you can't support sphinx 5? In my testing everything seems to work fine. It is also passing your CI tests. |
Can we at least make the pypa package consistent with the requirements on conda-forge? https://github.com/conda-forge/pydata-sphinx-theme-feedstock/blob/main/recipe/meta.yaml
|
For future readers, the upper bound was removed here: #661 |
I would like to test Sphinx==5.0.0.b1:
But I noticed that the most recent version of pydata-sphinx-theme pins on sphinx<5. Of course, I can just ignore that and test anyway.
According to the 5.0.0 release plan, Sphinx 5 should be released in a few weeks:
According to your CI, this project works just fine with Sphinx 5:
Would it be possible to to make a pydata-sphinx-theme 0.8.2 with the upperbound unpinned (or at least incremented so folks don't see the warning)? Personally, I would remove the upper bound entirely.
The text was updated successfully, but these errors were encountered: