From bf27549d04cbc0a297cb1b65c12809f6b127ca69 Mon Sep 17 00:00:00 2001 From: 12rambau Date: Sat, 4 Feb 2023 10:28:34 +0100 Subject: [PATCH 1/6] add fa icons instead of emoji --- docs/index.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/index.md b/docs/index.md index f39c674ad..af08633b6 100644 --- a/docs/index.md +++ b/docs/index.md @@ -14,18 +14,18 @@ A clean, Bootstrap-based Sphinx theme by and for [the PyData community](https:// ```{gallery-grid} :grid-columns: 1 2 2 3 -- header: "{guilabel}`B` Built with Bootstrap" +- header: "{fab}`bootstrap;sd-text-primary` Built with Bootstrap" content: "Use Bootstrap classes and functionality in your documentation." -- header: "⚡ Responsive Design" +- header: "{fas}`bolt;sd-text-primary` Responsive Design" content: "Site sections will change behavior and size at different screen sizes." -- header: "🌗 Light / Dark theme" +- header: "{fas}`circle-half-stroke;sd-text-primary` Light / Dark theme" content: "Users can toggle between light and dark themes interactively." -- header: "🎨 Customizable UI and themes" +- header: "{fas}`palette;sd-text-primary` Customizable UI and themes" content: "Customize colors and branding with CSS variables, and build custom UIs with [Sphinx Design](user_guide/web-components)." -- header: "{fab}`python` Supports PyData and Jupyter" +- header: "{fab}`python;sd-text-primary` Supports PyData and Jupyter" content: "CSS and UI support for Jupyter extensions and PyData execution outputs." link: "examples/pydata.html" -- header: "💡 Example Gallery" +- header: "{fas}`lightbulb;sd-text-primary` Example Gallery" content: "See our gallery of projects that use this theme." link: "examples/gallery.html" ``` From 934884a5c251aba4a9d388e02b1d4175dd9c1e5e Mon Sep 17 00:00:00 2001 From: 12rambau Date: Sat, 4 Feb 2023 10:29:50 +0100 Subject: [PATCH 2/6] remove fix for emojis --- .github/workflows/tests.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5d4cf158a..47d1e7a13 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -104,11 +104,7 @@ jobs: cache: "pip" cache-dependency-path: "pyproject.toml" - name: Install dependencies - shell: bash - # setting shell to BASH and using PYTHONUTF8 env var makes the editable - # install work on Windows even though there are emoji in our README run: | - export PYTHONUTF8=1 python -m pip install --upgrade pip wheel setuptools python -m pip install -e .[doc] - name: Show installed versions From ee852f4dae17c00ed141d38f39ef6cb998dd4aff Mon Sep 17 00:00:00 2001 From: 12rambau Date: Sat, 4 Feb 2023 10:42:28 +0100 Subject: [PATCH 3/6] use markup for readme emojis --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 283742569..a1df147e6 100644 --- a/README.md +++ b/README.md @@ -8,9 +8,9 @@ A clean, three-column, Bootstrap-based Sphinx theme by and for the [PyData community](https://pydata.org). -- 📚 Documentation: https://pydata-sphinx-theme.readthedocs.io/en/stable -- 💡 Examples: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples -- 🙌 Contribute: https://pydata-sphinx-theme.readthedocs.io/en/stable/community +- :books: Documentation: https://pydata-sphinx-theme.readthedocs.io/en/stable +- :bulb: Examples: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples +- :raised_hands: Contribute: https://pydata-sphinx-theme.readthedocs.io/en/stable/community [![Example documentation with this theme](./docs/_static/theme_landing.png)](https://pydata-sphinx-theme.readthedocs.io/en/stable) From 1485849b14b9d6ad2ea0e3d1ad5eef6278d940db Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Tue, 7 Feb 2023 12:43:30 -0600 Subject: [PATCH 4/6] use pst-color-primary instead of sd-text-primary --- docs/index.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/index.md b/docs/index.md index af08633b6..795f339cc 100644 --- a/docs/index.md +++ b/docs/index.md @@ -14,18 +14,18 @@ A clean, Bootstrap-based Sphinx theme by and for [the PyData community](https:// ```{gallery-grid} :grid-columns: 1 2 2 3 -- header: "{fab}`bootstrap;sd-text-primary` Built with Bootstrap" +- header: "{fab}`bootstrap;pst-color-primary` Built with Bootstrap" content: "Use Bootstrap classes and functionality in your documentation." -- header: "{fas}`bolt;sd-text-primary` Responsive Design" +- header: "{fas}`bolt;pst-color-primary` Responsive Design" content: "Site sections will change behavior and size at different screen sizes." -- header: "{fas}`circle-half-stroke;sd-text-primary` Light / Dark theme" +- header: "{fas}`circle-half-stroke;pst-color-primary` Light / Dark theme" content: "Users can toggle between light and dark themes interactively." -- header: "{fas}`palette;sd-text-primary` Customizable UI and themes" +- header: "{fas}`palette;pst-color-primary` Customizable UI and themes" content: "Customize colors and branding with CSS variables, and build custom UIs with [Sphinx Design](user_guide/web-components)." -- header: "{fab}`python;sd-text-primary` Supports PyData and Jupyter" +- header: "{fab}`python;pst-color-primary` Supports PyData and Jupyter" content: "CSS and UI support for Jupyter extensions and PyData execution outputs." link: "examples/pydata.html" -- header: "{fas}`lightbulb;sd-text-primary` Example Gallery" +- header: "{fas}`lightbulb;pst-color-primary` Example Gallery" content: "See our gallery of projects that use this theme." link: "examples/gallery.html" ``` From 6469413fb996529e0edd40335a3803a18340b02e Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Tue, 7 Feb 2023 14:30:16 -0600 Subject: [PATCH 5/6] make our semantic colors available as classes --- src/pydata_sphinx_theme/assets/styles/variables/_color.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pydata_sphinx_theme/assets/styles/variables/_color.scss b/src/pydata_sphinx_theme/assets/styles/variables/_color.scss index 7e4e9b8e7..dc2752347 100644 --- a/src/pydata_sphinx_theme/assets/styles/variables/_color.scss +++ b/src/pydata_sphinx_theme/assets/styles/variables/_color.scss @@ -94,6 +94,10 @@ $pst-semantic-colors: ( $value: map-get($value, $mode); } --pst-color-#{$name}: #{$value}; + // assign classes too, for runtime use of theme colors + .pst-color-#{$name} { + color: #{$value}; + } } // assign the "duplicate" colors (ones that just reference other variables) --pst-color-link: var(--pst-color-primary); From 14eba0de3f646ea31ff02b7914e9c9033fd51a61 Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Tue, 7 Feb 2023 14:52:10 -0600 Subject: [PATCH 6/6] try again --- .../assets/styles/variables/_color.scss | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/pydata_sphinx_theme/assets/styles/variables/_color.scss b/src/pydata_sphinx_theme/assets/styles/variables/_color.scss index dc2752347..c7b85341c 100644 --- a/src/pydata_sphinx_theme/assets/styles/variables/_color.scss +++ b/src/pydata_sphinx_theme/assets/styles/variables/_color.scss @@ -94,10 +94,6 @@ $pst-semantic-colors: ( $value: map-get($value, $mode); } --pst-color-#{$name}: #{$value}; - // assign classes too, for runtime use of theme colors - .pst-color-#{$name} { - color: #{$value}; - } } // assign the "duplicate" colors (ones that just reference other variables) --pst-color-link: var(--pst-color-primary); @@ -133,3 +129,10 @@ $pst-semantic-colors: ( } } } + +// assign classes too, for runtime use of theme colors +@each $name, $value in $pst-semantic-colors { + .pst-color-#{$name} { + color: var(--pst-color-#{$name}); + } +}