From 56b09f3eb01aad41c6554bfd9981600ddc61168b Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Tue, 19 Jan 2021 15:59:05 -0500 Subject: [PATCH 1/2] MAINT: Work around Sphinx deprecation --- pydata_sphinx_theme/bootstrap_html_translator.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pydata_sphinx_theme/bootstrap_html_translator.py b/pydata_sphinx_theme/bootstrap_html_translator.py index f18320692..e8543089d 100644 --- a/pydata_sphinx_theme/bootstrap_html_translator.py +++ b/pydata_sphinx_theme/bootstrap_html_translator.py @@ -24,7 +24,11 @@ def visit_table(self, node): # type: (nodes.Element) -> None # copy of sphinx source to *not* add 'docutils' and 'align-default' classes # but add 'table' class - self.generate_targets_for_table(node) + + # generate_targets_for_table is deprecated in 4.0, so use equivalent code: + for id_ in node['ids'][1:]: + self.body.append('' % id_) + node['ids'].remove(id_) self._table_row_index = 0 From 6a67153dbecd94f52cc64b8d5d86eabc701c87ba Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 25 Jan 2021 12:05:53 -0500 Subject: [PATCH 2/2] FIX: Version-dependent --- pydata_sphinx_theme/bootstrap_html_translator.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pydata_sphinx_theme/bootstrap_html_translator.py b/pydata_sphinx_theme/bootstrap_html_translator.py index e8543089d..3857f9a5a 100644 --- a/pydata_sphinx_theme/bootstrap_html_translator.py +++ b/pydata_sphinx_theme/bootstrap_html_translator.py @@ -1,7 +1,9 @@ """A custom Sphinx HTML Translator for Bootstrap layout """ +from distutils.version import LooseVersion from docutils import nodes +import sphinx from sphinx.writers.html5 import HTML5Translator from sphinx.util import logging from sphinx.ext.autosummary import autosummary_table @@ -25,10 +27,9 @@ def visit_table(self, node): # copy of sphinx source to *not* add 'docutils' and 'align-default' classes # but add 'table' class - # generate_targets_for_table is deprecated in 4.0, so use equivalent code: - for id_ in node['ids'][1:]: - self.body.append('' % id_) - node['ids'].remove(id_) + # generate_targets_for_table is deprecated in 4.0 + if LooseVersion(sphinx.__version__) < LooseVersion("4.0"): + self.generate_targets_for_table(node) self._table_row_index = 0