rework tests

Author: dcherian

xarray/tests/test_groupby.py

@@ -1133,26 +1133,28 @@ def change_metadata(x):
         expected = change_metadata(expected)
         assert_equal(expected, actual)
 
-    def test_groupby_math(self):
+    @pytest.mark.parametrize("squeeze", [True, False])
+    def test_groupby_math_squeeze(self, squeeze):
         array = self.da
-        for squeeze in [True, False]:
-            grouped = array.groupby("x", squeeze=squeeze)
+        grouped = array.groupby("x", squeeze=squeeze)
 
-            expected = array + array.coords["x"]
-            actual = grouped + array.coords["x"]
-            assert_identical(expected, actual)
+        expected = array + array.coords["x"]
+        actual = grouped + array.coords["x"]
+        assert_identical(expected, actual)
 
-            actual = array.coords["x"] + grouped
-            assert_identical(expected, actual)
+        actual = array.coords["x"] + grouped
+        assert_identical(expected, actual)
 
-            ds = array.coords["x"].to_dataset(name="X")
-            expected = array + ds
-            actual = grouped + ds
-            assert_identical(expected, actual)
+        ds = array.coords["x"].to_dataset(name="X")
+        expected = array + ds
+        actual = grouped + ds
+        assert_identical(expected, actual)
 
-            actual = ds + grouped
-            assert_identical(expected, actual)
+        actual = ds + grouped
+        assert_identical(expected, actual)
 
+    def test_groupby_math(self):
+        array = self.da
         grouped = array.groupby("abc")
         expected_agg = (grouped.mean(...) - np.arange(3)).rename(None)
         actual = grouped - DataArray(range(3), [("abc", ["a", "b", "c"])])