Skip to content

Commit 4e9535a

Browse files
authored
Fix polyval overloads (#7315)
* fix polyval overloads * add to whatsnew
1 parent fb42ef9 commit 4e9535a

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

doc/whats-new.rst

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ Bug fixes
5757

5858
- Import ``nc_time_axis`` when needed (:issue:`7275`, :pull:`7276`).
5959
By `Michael Niklas <https://github.com/headtr1ck>`_.
60+
- Fix static typing of :py:meth:`xr.polyval` (:issue:`7312`, :pull:`7315`).
61+
By `Michael Niklas <https://github.com/headtr1ck>`_.
6062

6163
Documentation
6264
~~~~~~~~~~~~~

xarray/core/computation.py

+12-4
Original file line numberDiff line numberDiff line change
@@ -1876,22 +1876,30 @@ def where(cond, x, y, keep_attrs=None):
18761876

18771877

18781878
@overload
1879-
def polyval(coord: DataArray, coeffs: DataArray, degree_dim: Hashable) -> DataArray:
1879+
def polyval(
1880+
coord: DataArray, coeffs: DataArray, degree_dim: Hashable = "degree"
1881+
) -> DataArray:
18801882
...
18811883

18821884

18831885
@overload
1884-
def polyval(coord: DataArray, coeffs: Dataset, degree_dim: Hashable) -> Dataset:
1886+
def polyval(
1887+
coord: DataArray, coeffs: Dataset, degree_dim: Hashable = "degree"
1888+
) -> Dataset:
18851889
...
18861890

18871891

18881892
@overload
1889-
def polyval(coord: Dataset, coeffs: DataArray, degree_dim: Hashable) -> Dataset:
1893+
def polyval(
1894+
coord: Dataset, coeffs: DataArray, degree_dim: Hashable = "degree"
1895+
) -> Dataset:
18901896
...
18911897

18921898

18931899
@overload
1894-
def polyval(coord: Dataset, coeffs: Dataset, degree_dim: Hashable) -> Dataset:
1900+
def polyval(
1901+
coord: Dataset, coeffs: Dataset, degree_dim: Hashable = "degree"
1902+
) -> Dataset:
18951903
...
18961904

18971905

0 commit comments

Comments
 (0)