pytest.warns needs a warning

Author: max-sixty

xarray/tests/test_coding_times.py

@@ -166,7 +166,7 @@ def test_decode_non_standard_calendar_single_element_fallback(self):
         dt = nc4.netcdftime.datetime(2001, 2, 29)
         for calendar in ['360_day', 'all_leap', '366_day']:
             num_time = nc4.date2num(dt, units, calendar)
-            with pytest.warns('Unable to decode time axis'):
+            with pytest.warns(Warning, 'Unable to decode time axis'):
                 actual = coding.times.decode_cf_datetime(num_time, units,
                                                          calendar=calendar)
             expected = np.asarray(nc4.num2date(num_time, units, calendar))

xarray/tests/test_conventions.py

@@ -197,7 +197,7 @@ def test_incompatible_attributes(self):
     def test_missing_fillvalue(self):
         v = Variable(['x'], np.array([np.nan, 1, 2, 3]))
         v.encoding = {'dtype': 'int16'}
-        with pytest.warns('floating point data as an integer'):
+        with pytest.warns(Warning, 'floating point data as an integer'):
             conventions.encode_cf_variable(v)
 
     def test_multidimensional_coordinates(self):

xarray/tests/test_extensions.py

@@ -53,7 +53,7 @@ def foo(self):
         del xr.Dataset.demo
         assert not hasattr(xr.Dataset, 'demo')
 
-        with pytest.warns('overriding a preexisting attribute'):
+        with pytest.warns(Warning, 'overriding a preexisting attribute'):
             @xr.register_dataarray_accessor('demo')
             class Foo(object):
                 pass

xarray/tests/test_utils.py

@@ -18,7 +18,7 @@ def new_method():
             pass
         old_method = utils.alias(new_method, 'old_method')
         assert 'deprecated' in old_method.__doc__
-        with pytest.warns('deprecated'):
+        with pytest.warns(Warning, 'deprecated'):
             old_method()