PKG: Explicitly add setuptools dependency (#3628)

* PKG: Explicitly add setuptools dependency

* PKG: Remove setuptools MONTHS policy

* Code review

* Display setuptools in github dependency graph

* setuptools minimum version

Co-authored-by: crusaderky <[email protected]>

Author: hoechenberger

.binder/environment.yml

@@ -31,6 +31,7 @@ dependencies:
   - rasterio
   - scipy
   - seaborn
+  - setuptools
   - sparse
   - toolz
   - xarray

ci/requirements/doc.yml

@@ -20,6 +20,7 @@ dependencies:
   - pandas
   - rasterio
   - seaborn
+  - setuptools
   - sphinx
   - sphinx_rtd_theme
   - zarr

ci/requirements/py36-bare-minimum.yml

@@ -10,3 +10,4 @@ dependencies:
   - pytest-env
   - numpy=1.15
   - pandas=0.25
+  - setuptools=41.2

ci/requirements/py36-min-all-deps.yml

@@ -43,6 +43,7 @@ dependencies:
   - rasterio=1.0
   - scipy=1.3
   - seaborn=0.9
+  - setuptools=41.2
   # - sparse  # See py36-min-nep18.yml
   - toolz=0.10
   - zarr=2.3

ci/requirements/py36-min-nep18.yml

@@ -16,4 +16,5 @@ dependencies:
   - pytest-cov
   - pytest-env
   - scipy=1.2
+  - setuptools=41.2
   - sparse=0.8

ci/requirements/py36.yml

@@ -39,6 +39,7 @@ dependencies:
   - rasterio
   - scipy
   - seaborn
+  - setuptools
   - sparse
   - toolz
   - zarr

ci/requirements/py37-windows.yml

@@ -39,6 +39,7 @@ dependencies:
   - rasterio
   - scipy
   - seaborn
+  - setuptools
   - sparse
   - toolz
   - zarr

ci/requirements/py37.yml

@@ -39,6 +39,7 @@ dependencies:
   - rasterio
   - scipy
   - seaborn
+  - setuptools
   - sparse
   - toolz
   - zarr

ci/requirements/py38.yml

@@ -3,6 +3,7 @@ channels:
   - conda-forge
 dependencies:
   - python=3.8
+  - setuptools
   - pip
   - pip:
       - coveralls

doc/installing.rst

@@ -7,6 +7,7 @@ Required dependencies
 ---------------------
 
 - Python (3.6 or later)
+- setuptools
 - `numpy <http://www.numpy.org/>`__ (1.15 or later)
 - `pandas <http://pandas.pydata.org/>`__ (0.25 or later)
 

doc/whats-new.rst

@@ -150,6 +150,8 @@ Bug fixes
 - Allow plotting of binned coordinates on the y axis in :py:meth:`plot.line`
   and :py:meth:`plot.step` plots (:issue:`3571`,
   :pull:`3685`) by `Julien Seguinot <https://github.com/juseg>`_.
+- setuptools is now marked as a dependency of xarray
+  (:pull:`3628`) by `Richard Höchenberger <https://github.com/hoechenberger>`_.
 
 Documentation
 ~~~~~~~~~~~~~

requirements.txt

@@ -4,3 +4,4 @@
 
 numpy >= 1.15
 pandas >= 0.25
+setuptools >= 41.2

setup.cfg

@@ -76,7 +76,10 @@ python_requires = >=3.6
 install_requires =
     numpy >= 1.15
     pandas >= 0.25
-setup_requires = setuptools_scm
+    setuptools >= 41.2  # For pkg_resources
+setup_requires =
+    setuptools >= 41.2
+    setuptools_scm
 
 [options.package_data]
 xarray =

xarray/__init__.py

@@ -1,3 +1,5 @@
+import pkg_resources
+
 from . import testing, tutorial, ufuncs
 from .backends.api import (
     load_dataarray,
@@ -27,11 +29,9 @@
 from .util.print_versions import show_versions
 
 try:
-    import pkg_resources
-
     __version__ = pkg_resources.get_distribution("xarray").version
 except Exception:
-    # Local copy, not installed with setuptools, or setuptools is not available.
+    # Local copy or not installed with setuptools.
     # Disable minimum version checks on downstream libraries.
     __version__ = "999"