Skip to content

Commit ee0bf6e

Browse files
committed
add suggestions from review
1 parent b617924 commit ee0bf6e

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

doc/whats-new.rst

+3
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ Breaking changes
4747
``"S"``, ``"L"``, ``"U"``, or ``"N"``. This is to be consistent with the
4848
deprecation of the latter frequency strings (:issue:`8394`, :pull:`8415`). By
4949
`Spencer Clark <https://github.com/spencerkclark>`_.
50+
By `Justus Magin <https://github.com/keewis`_.
5051
- Bump minimum tested pint version to ``>=0.22``. By `Deepak Cherian <https://github.com/dcherian>`_.
52+
- Minimum supported versions for the following packages have changed: ``h5py >=3.7``, ``h5netcdf>=1.1``.
53+
By `Kai Mühlbauer <https://github.com/kmuehlbauer>`_.
5154

5255
Deprecations
5356
~~~~~~~~~~~~

xarray/coding/variables.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def decode(self):
564564
raise NotImplementedError()
565565

566566

567-
class ObjectStringCoder(VariableCoder):
567+
class ObjectVLenStringCoder(VariableCoder):
568568
def encode(self):
569569
return NotImplementedError
570570

xarray/conventions.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def decode_cf_variable(
266266
var = strings.EncodedStringCoder().decode(var)
267267

268268
if original_dtype == object:
269-
var = variables.ObjectStringCoder().decode(var)
269+
var = variables.ObjectVLenStringCoder().decode(var)
270270
original_dtype = var.dtype
271271

272272
if mask_and_scale:

0 commit comments

Comments
 (0)