-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Code review bots? #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sure, automated comments on a pull request are definitely friendlier than a failed Travis-CI build. |
Let me know if you don't have the permissions to add it and I should be able to help. |
I think we can remove the flake8 test in travis. |
Per comment on the pull: my experience is that bots are a great complement, but can't replace style checks in CI. Only remove flake8 from Travis if you're OK with merging pulls that don't meet the style guide (and then amend the contributing guide to match) - that's a valid decision, but also a weaker position than Xarray has previously taken. |
I'm seeing them from time to time on other repositories. One that seems reasonable and not toooo intrusive is stickler, for code style review: https://stickler-ci.com/
The text was updated successfully, but these errors were encountered: