Skip to content

Code review bots? #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmaussion opened this issue Feb 15, 2018 · 4 comments
Closed

Code review bots? #1912

fmaussion opened this issue Feb 15, 2018 · 4 comments

Comments

@fmaussion
Copy link
Member

I'm seeing them from time to time on other repositories. One that seems reasonable and not toooo intrusive is stickler, for code style review: https://stickler-ci.com/

@shoyer
Copy link
Member

shoyer commented Feb 15, 2018

Sure, automated comments on a pull request are definitely friendlier than a failed Travis-CI build.

@shoyer
Copy link
Member

shoyer commented Feb 15, 2018

Let me know if you don't have the permissions to add it and I should be able to help.

@fujiisoup
Copy link
Member

I think we can remove the flake8 test in travis.
It would make clear on github whether tests fail or code style issues.

@Zac-HD
Copy link
Contributor

Zac-HD commented Feb 28, 2018

Per comment on the pull: my experience is that bots are a great complement, but can't replace style checks in CI.

Only remove flake8 from Travis if you're OK with merging pulls that don't meet the style guide (and then amend the contributing guide to match) - that's a valid decision, but also a weaker position than Xarray has previously taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants