Skip to content

isnull loads dask array #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fujiisoup opened this issue Feb 23, 2018 · 0 comments · Fixed by #1939
Closed

isnull loads dask array #1937

fujiisoup opened this issue Feb 23, 2018 · 0 comments · Fixed by #1939
Labels

Comments

@fujiisoup
Copy link
Member

From gitter
cc. @davidh-ssec

In [1]: import numpy as np
   ...: import xarray as xr
   ...: 
   ...: da = xr.DataArray(np.arange(100), dims='x').chunk({'x': 10})
   ...: da.isnull()
   ...: 
Out[1]: 
<xarray.DataArray (x: 100)>
array([False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False,
       False, False, False, False, False, False, False, False, False, False], dtype=bool)
Dimensions without coordinates: x

Problem description

DataArray.isnull() automatically computes dask arrays.

Expected Output

Out[2]: 
<xarray.DataArray (x: 100)>
dask.array<shape=(100,), dtype=bool, chunksize=(10,)>
Dimensions without coordinates: x

Cause

xarray/xarray/core/ops.py

Lines 322 to 324 in 697cc74

for name in PANDAS_UNARY_FUNCTIONS:
f = _func_slash_method_wrapper(getattr(pd, name), name=name)
setattr(cls, name, cls._unary_op(f))

Here, getattr(pd, name) should be getattr(duck_array_ops, name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant