Skip to content

isort flags #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
keewis opened this issue Jul 4, 2020 · 0 comments · Fixed by #4204
Closed

isort flags #4202

keewis opened this issue Jul 4, 2020 · 0 comments · Fixed by #4204

Comments

@keewis
Copy link
Collaborator

keewis commented Jul 4, 2020 •
edited
Loading

Because I've been hit by this elsewhere: isort has released a new version today that removes the -rc / --recursive flag (without deprecation, I think). Once conda-forge has been updated, we will start seeing a failing isort CI.

Not sure if we should pin isort for now or simply remove the flag once the builds are failing (or we remove the flag now and have a pretty much useless isort CI until the feedstock has been merged).

Update: isort relaxed the error into a warning, so this is not that urgent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update isort CI and pre-commit hook keewis/xarray
1 participant
@keewis